Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/shared cache mk2 #581

Merged
merged 35 commits into from
Nov 26, 2021
Merged

Feat/shared cache mk2 #581

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
72c6cfc
WIP: Shared caches, 2nd attempt
loewenheim Nov 11, 2021
475976d
some more wip moving this in the right direction
Nov 15, 2021
31ef6ae
Add ./shared_cache/ to .gitignore
loewenheim Nov 15, 2021
f7ce904
Minor reorg in cache computation
Nov 15, 2021
cef67b6
Start fixing up some infra
Nov 15, 2021
b80ce93
compiles, at last
Nov 15, 2021
5a0a645
Remove bucket prefix
Nov 16, 2021
2549a85
Strongly type cache names
Nov 16, 2021
47a9dea
Introduce a SharedCacheKey instead of String/Path
Nov 16, 2021
435a895
Move metrics into the shared cache service
Nov 16, 2021
492a455
Use generic writer instead of passing a path around
Nov 16, 2021
be783e6
Rework how the various cache lookups happen
Nov 17, 2021
1a01e93
Avoid re-opening same file over and over again
Nov 18, 2021
ccbd8ab
Make tests work again
Nov 18, 2021
9d5a44c
Implement gcs read
Nov 22, 2021
a06187c
Implement store for GCS
loewenheim Nov 22, 2021
72fd99d
oops, new file
Nov 22, 2021
e8fa550
Make GCS store compile
Nov 23, 2021
7a20f72
hello clippy
Nov 23, 2021
30ddc9d
Do not copy the contents of files being put into shared cache
Nov 23, 2021
0b115da
Update comments
Nov 23, 2021
a440f22
Avoid an extra seek
Nov 23, 2021
d228c80
Handle not found in shared caches correctly
Nov 23, 2021
9b25619
Do errors correctly
Nov 23, 2021
74b6d01
Slightly nicer way to add context to errors
Nov 24, 2021
a54f6b5
Start adding tests: filesystem only for now
Nov 25, 2021
bb08864
Stop duplicating the gcs test key retrieval
Nov 25, 2021
0cefef6
Add test for GCS
Nov 25, 2021
f421344
super minor phrasing change
relaxolotl Nov 26, 2021
49a3819
get tokens that allow writing to gcs
relaxolotl Nov 26, 2021
92274e5
only write files to the shared cache if they're not already there
relaxolotl Nov 26, 2021
5e5113b
Tidy up logging and metrics
Nov 26, 2021
92e742c
Tighten not found detection
Nov 26, 2021
d1e69fd
We already stream the body
Nov 26, 2021
8b4321e
Add readme
Nov 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ __pycache__
/local.yml
/cache/
/symbols/
/shared_cache/

# mkdocs
site
34 changes: 20 additions & 14 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/symbolicator/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ serde = { version = "1.0.119", features = ["derive", "rc"] }
serde_json = "1.0.61"
serde_yaml = "0.8.15"
structopt = "0.3.21"
symbolic = { git = "https://github.com/getsentry/symbolic", branch = "fix/demangle-fixes", version = "8.3.0", features = ["common-serde", "debuginfo", "demangle", "minidump-serde", "symcache"] }
symbolic = { git = "https://github.com/getsentry/symbolic", branch = "fix/demangle-fixes", version = "8.5.0", features = ["common-serde", "debuginfo", "demangle", "minidump-serde", "symcache"] }
# Uncomment the line below for local development
# symbolic = { path = "../../../symbolic/symbolic", version = "8.3.0", features = ["common-serde", "debuginfo", "demangle", "minidump-serde", "symcache"] }
tempfile = "3.2.0"
Expand Down
Loading