-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Remove breakpad stackwalking code (NATIVE-522) #731
Conversation
Instructions for snapshot changesSentry runs a symbolicator integration test suite located at Follow these steps to update snapshots in Sentry:
|
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 71.96% 73.25% +1.28%
==========================================
Files 48 48
Lines 11093 10838 -255
==========================================
- Hits 7983 7939 -44
+ Misses 3110 2899 -211
Continue to review full report at Codecov.
|
The snapshots have these changes, as I now append the
|
dd24d70
to
1d9fb4d
Compare
This is now blocked by getsentry/sentry#32871 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't wait to see this merged :)
😸🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This is on top of #723, and completely removes breakpad from the codebase, and the build.
As this switches from breakpad to rust-minidump by default, the effect on a quick
wrk
shows that rps went from ~270 to ~360 for a very nice win.