feat: Add native crash reporter #795
Conversation
This adds an optional native crash reporter modeled on `relay-crash`.
| @@ -0,0 +1,3 @@ | |||
| [submodule "crates/symbolicator-crash/sentry-native"] | |||
| path = crates/symbolicator-crash/sentry-native | |||
| url = https://github.com/getsentry/sentry-native | |||
There was a problem hiding this comment.
oh no, do does this force us to use submodules? i really don't get on with them
There was a problem hiding this comment.
Fraid so. I guess extracting this into its own crate would also save symbolicator from this fate?
| fn main() { | ||
| // sentry-native dependencies | ||
| match std::env::var("CARGO_CFG_TARGET_OS").unwrap().as_str() { | ||
| "macos" => println!("cargo:rustc-link-lib=dylib=c++"), |
There was a problem hiding this comment.
we don't support symbolicator on mac do we? not that it does any harm. and as you say perhaps better as a separate crate at some point
| // we never need a debug build of sentry-native | ||
| .profile("RelWithDebInfo") | ||
| // always build breakpad regardless of platform defaults | ||
| .define("SENTRY_BACKEND", "breakpad") |
There was a problem hiding this comment.
how does breakpad work? will it work correctly in our k8s setup?
There was a problem hiding this comment.
If this is built exactly the same way as relay-crash, then yes. However, this also needs something similar to: https://github.com/getsentry/ops/pull/4158. We have the volume, but we need the config.
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
==========================================
- Coverage 75.37% 75.19% -0.18%
==========================================
Files 49 51 +2
Lines 10861 10945 +84
==========================================
+ Hits 8186 8230 +44
- Misses 2675 2715 +40
Continue to review full report at Codecov.
|
feat: Add native crash reporter This adds an optional native crash reporter modeled on `relay-crash`.
This adds an optional native crash reporter modeled on
relay-crash.Sentry can use, modify, copy, and redistribute this contribution, under Sentry's choice of terms.
Note: the code of
symbolicator-crashis identical to that ofrelay-crash(modulo such things as version numbers and descriptions). In principle there's no reason it couldn't be extracted into its own crate.