feat: Use il2cpp line mappings in symcache creation #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `Il2cppService`, modeled after `BitcodeService`, that is responsible for downloading il2cpp line mapping files. `SymCacheActor` can then use these files when generating symcaches. This PR also contains a drive-by refactoring of path handling logic. The function `get_search_target_object_type` computed an object type from a file type and identifier, which was then used to compute an ID. I removed the indirection in favor of computing the ID from the given file type and identifier directly.
Swatinem
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
Il2cppService, modeled afterBitcodeService, that is responsible for downloading il2cpp line mapping files.SymCacheActorcan then use these files when generating symcaches.This PR also contains a drive-by refactoring of path handling logic. The function
get_search_target_object_typecomputed an object type from a file type and identifier, which was then used to compute an ID. I removed the indirection in favor of computing the ID from the givenfile type and identifier directly.
ETA: This depends upon getsentry/symbolic#592.