Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove DownloadError in favor of CacheError #956

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Dec 30, 2022

Also deduplicates a bunch of downloader code that matches on response statuses.

Fixes #930.

#skip-changelog

@codecov-commenter
Copy link

Codecov Report

Base: 65.95% // Head: 66.83% // Increases project coverage by +0.88% 🎉

Coverage data is based on head (87c3826) compared to base (ac4e0a9).
Patch coverage: 59.31% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #956      +/-   ##
==========================================
+ Coverage   65.95%   66.83%   +0.88%     
==========================================
  Files          74       74              
  Lines       11754    11570     -184     
==========================================
- Hits         7752     7733      -19     
+ Misses       4002     3837     -165     
Impacted Files Coverage Δ
...tes/symbolicator-service/src/services/cficaches.rs 81.94% <ø> (ø)
...mbolicator-service/src/services/download/sentry.rs 22.28% <0.00%> (+3.88%) ⬆️
...es/symbolicator-service/src/services/fetch_file.rs 33.33% <ø> (+16.66%) ⬆️
...s/symbolicator-service/src/services/ppdb_caches.rs 85.89% <ø> (ø)
...symbolicator-service/src/services/symcaches/mod.rs 88.63% <ø> (ø)
crates/symbolicator-service/src/types/objects.rs 94.04% <ø> (+5.03%) ⬆️
crates/symbolicator-service/src/utils/futures.rs 75.00% <ø> (-3.08%) ⬇️
.../symbolicator-service/src/services/download/gcs.rs 50.24% <18.18%> (+8.95%) ⬆️
...rates/symbolicator-service/src/services/derived.rs 85.41% <30.00%> (-14.59%) ⬇️
...s/symbolicator-service/src/services/download/s3.rs 43.95% <38.02%> (+6.63%) ⬆️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Also deduplicates a bunch of downloader code that matches on response statuses.
@Swatinem Swatinem marked this pull request as ready for review January 9, 2023 13:00
@Swatinem Swatinem requested a review from a team January 9, 2023 13:00
@Swatinem Swatinem merged commit 9c21811 into master Jan 9, 2023
@Swatinem Swatinem deleted the ref/downloaderror branch January 9, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up download retry logic
3 participants