Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Replace last LRU caches with moka #978

Merged
merged 6 commits into from
Jan 17, 2023
Merged

ref: Replace last LRU caches with moka #978

merged 6 commits into from
Jan 17, 2023

Conversation

loewenheim
Copy link
Contributor

No description provided.

@loewenheim loewenheim requested a review from a team January 16, 2023 10:39
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 69.24% // Head: 69.38% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (39eeaa1) compared to base (c89f25e).
Patch coverage: 71.69% of modified lines in pull request are covered.

❗ Current head 39eeaa1 differs from pull request most recent head 6c24cc5. Consider uploading reports for the commit 6c24cc5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
+ Coverage   69.24%   69.38%   +0.13%     
==========================================
  Files          74       74              
  Lines       11563    11540      -23     
==========================================
  Hits         8007     8007              
+ Misses       3556     3533      -23     
Impacted Files Coverage Δ
crates/symbolicator-service/src/config.rs 84.01% <ø> (ø)
...s/symbolicator-service/src/services/download/s3.rs 47.68% <0.00%> (ø)
crates/symbolicator-service/src/types/mod.rs 75.26% <50.00%> (+2.00%) ⬆️
.../symbolicator-service/src/services/download/gcs.rs 63.47% <65.21%> (+3.22%) ⬆️
crates/symbolicator/src/endpoints/requests.rs 95.65% <66.66%> (ø)
...mbolicator-service/src/services/download/sentry.rs 67.08% <80.00%> (+5.64%) ⬆️
crates/symbolicator-service/src/utils/addr.rs 88.23% <100.00%> (-0.96%) ⬇️
crates/symbolicator-sources/src/sources.rs 84.61% <100.00%> (-0.57%) ⬇️
crates/symbolicator-sources/src/sources/s3.rs 90.14% <100.00%> (-0.10%) ⬇️
crates/symbolicator-sources/src/types.rs 87.71% <100.00%> (-0.42%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

"Fetching list of Sentry debug files from {}",
&query.index_url
);
let query_ = query.clone();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swatinem Do you see a way to avoid this clone under a new name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, except creating a block just to create the future, though I wanted to explicitly avoid excessive rightward drift

@loewenheim loewenheim merged commit 6c2a4ad into master Jan 17, 2023
@loewenheim loewenheim deleted the ref/remove-lru branch January 17, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants