-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Replace last LRU caches with moka #978
Conversation
Codecov ReportBase: 69.24% // Head: 69.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 69.24% 69.38% +0.13%
==========================================
Files 74 74
Lines 11563 11540 -23
==========================================
Hits 8007 8007
+ Misses 3556 3533 -23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
"Fetching list of Sentry debug files from {}", | ||
&query.index_url | ||
); | ||
let query_ = query.clone(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Swatinem Do you see a way to avoid this clone under a new name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, except creating a block just to create the future, though I wanted to explicitly avoid excessive rightward drift
No description provided.