fix: Use unique Cache files for symcaches with markers #982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives symcaches a unique cache key depending on the
secondary_sources
and the same cache file is not being reused with different sets ofsecondary_sources
.It also paves the way to avoid appending markers to files and thus getting rid of the
should_load
check in the future.This still does not solve the edge-case when any of the
secondary_sources
itself changes. But that is the same edge-case we currently have if files on external symbol sources are overwritten. As long as we have that file cached, we will never try to re-download that file.Cache files are considered to be immutable.
#skip-changelog