fix: Properly support NuGet symbols with SymbolChecksum #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #993 +/- ##
==========================================
- Coverage 74.26% 74.02% -0.25%
==========================================
Files 75 75
Lines 11504 11481 -23
==========================================
- Hits 8544 8499 -45
- Misses 2960 2982 +22 |
Swatinem
force-pushed
the
fix/nuget-src
branch
from
e1c8235
to
1003b97
Compare
loewenheim
approved these changes
Jan 30, 2023
Swatinem
force-pushed
the
fix/nuget-src
branch
2 times, most recently
from
e978cf0
to
45d44d2
Compare
Adds the `SymbolChecksum` header to HTTP sources if the `ObjectId` has a `debug_checksum` field. Also properly passes through that `debug_checksum` field from the incoming modules definition.
Swatinem
force-pushed
the
fix/nuget-src
branch
from
45d44d2
to
966be89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
SymbolChecksumheader to HTTP sources if theObjectIdhas adebug_checksumfield. Also properly passes through thatdebug_checksumfield from the incoming modules definition.This is still lacking proper tests, for which we would need an event that uses some .NET library that has symbols available on nuget. I suggest we do a proper integration test fetching things from upstream, as the upstream server at least checks for the presence of the header (even though it does not yet check the actual checksum, lol).
Apart from this, we should also make sure that the
debug_checksumfield is correctly passed through from sentry itself, and maybe also add the NuGet server as a builtin source in sentry, because why not…