Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Update contract licenses to MIT #608

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Update contract licenses to MIT #608

merged 4 commits into from
Jun 28, 2023

Conversation

jacque006
Copy link
Collaborator

@jacque006 jacque006 commented Jun 27, 2023

What is this PR doing?

  • Update SPDX-License-Identifier contract license metadata from Unlicense to MIT for consistency with rest of repo.
  • No other non-MIT license references were discovered

How can these changes be manually tested?

👀 , 🧑‍⚖️

Does this PR resolve or contribute to any issues?

Resolves #607

Checklist

I have manually tested these changes No testing needed

  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the contracts Smart contract related label Jun 27, 2023
@github-actions github-actions bot added aggregator Aggregator backend related aggregator-proxy Aggregator proxy related extension Browser extension related labels Jun 27, 2023
@jacque006
Copy link
Collaborator Author

Updating the SPDX-License-Identifier appears to have changed the contract bytecode. This will have conflicts with #606 depending on which goes in first (deps.ts, package.jsons, etc.)

@jacque006 jacque006 marked this pull request as ready for review June 27, 2023 20:56
Copy link
Collaborator

@JohnGuilding JohnGuilding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Only question is, should contracts/clients/package.json version be updated to 0.9.0-5d98448?

@jacque006
Copy link
Collaborator Author

jacque006 commented Jun 28, 2023

@JohnGuilding That clients version was pinned to an experimental release in main when I started this work. It doesn't seem to be causing any harm so I rolled with it.

When we pin v1, we can set it back to a non-experimental semver. Set it back in this PR

@jacque006 jacque006 merged commit 9476d34 into main Jun 28, 2023
@jacque006 jacque006 deleted the update-licenses-mit branch June 28, 2023 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aggregator Aggregator backend related aggregator-proxy Aggregator proxy related clients contracts Smart contract related extension Browser extension related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch all licensing to MIT
3 participants