TS & lint fixes

getwax · Apr 9, 2024 · 3ee3b07 · 3ee3b07
1 parent b486198
commit 3ee3b07
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/packages/demos/email-recovery/src/context/v2/AppContextProviderV2.tsx b/packages/demos/email-recovery/src/context/v2/AppContextProviderV2.tsx
@@ -33,7 +33,7 @@ export const AppContextProviderV2 = ({ children } : { children: ReactNode }) =>
 
         setRecoveryConfigs(updatedConfigs);
         localStorage.setItem(appContextLocalStorageKey, JSON.stringify(updatedConfigs));
-    }, []);
+    }, [recoveryConfigs]);
 
     const { data: isModuleEnabled } = useReadContract({
         address,
@@ -162,7 +162,8 @@ export const AppContextProviderV2 = ({ children } : { children: ReactNode }) =>
     }, [
         address,
         firstSafeOwner,
-        writeContractAsync
+        writeContractAsync,
+        setRecoveryConfig
     ])
 
     const requestRecovery = useCallback(async (newOwner: string) => {
@@ -190,7 +191,7 @@ export const AppContextProviderV2 = ({ children } : { children: ReactNode }) =>
         )
         console.debug('recovery request id', requestId)
         // TODO poll until recovery req is complete or fails
-    }, [recoveryRouterAddr, address])
+    }, [recoveryRouterAddr, address, getRecoveryConfig])
 
     const completeRecovery = useCallback(async () => {
         if (!recoveryRouterAddr) {
@@ -212,7 +213,7 @@ export const AppContextProviderV2 = ({ children } : { children: ReactNode }) =>
             {};
 
         setRecoveryConfigs(cfgs);
-    });
+    }, []);
 
     const ctxVal = useMemo(() => ({
         recoveryConfigs,

diff --git a/packages/demos/email-recovery/src/context/v2/AppContextV2.tsx b/packages/demos/email-recovery/src/context/v2/AppContextV2.tsx
@@ -27,13 +27,11 @@ type AppContextTypeV2 = {
 export const appContextV2 = createContext<AppContextTypeV2>({
     recoveryConfigs: {},
     // TODO Properly type return type, this will be overwritten in provider
-    getRecoveryConfig: (_address: string) => { return {} as any; },
-    setRecoveryConfig: (_cfg: RecoveryConfig) => {},
+    getRecoveryConfig: () => { return {} as any; },
+    setRecoveryConfig: () => {},
     isModuleEnabled: false,
     enableEmailRecoveryModule: async () => {},
-    configureRecoveryAndRequestGuardian: async(
-        _guardianEmail: string, _recoveryDelay: number
-    ) => {},
-    requestRecovery: async (_newOwner: string) => {},
+    configureRecoveryAndRequestGuardian: async() => {},
+    requestRecovery: async () => {},
     completeRecovery: async () => {},
 });
diff --git a/packages/demos/email-recovery/src/providers/Web3Provider.tsx b/packages/demos/email-recovery/src/providers/Web3Provider.tsx
@@ -5,7 +5,8 @@ import { ConnectKitProvider, getDefaultConfig } from "connectkit";
 import { PropsWithChildren } from "react";
 
 const connectKitOptions = {
-  walletConnectCTA: "both",
+  // TODO wat, why is cast needed?
+  walletConnectCTA: "both" as "both",
   walletConnectName: "WalletConnect",
   hideNoWalletCTA: true,
 };