Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.title doesn't make it to templates for mono-lingual sites on 0.15.0 #1687

Closed
cbiffle opened this issue Dec 7, 2021 · 7 comments
Closed
Labels

Comments

@cbiffle
Copy link
Contributor

cbiffle commented Dec 7, 2021

Bug Report

Environment

Zola version: 0.15.0 (Arch Linux package)

Expected Behavior

My templates correctly display the site title and description using {{ config.title }} and {{ config.description }}, respectively, on 0.14.0

Current Behavior

Both those variables now interpolate as empty strings.

Amusingly I can "fix" this by adding default_language = "fi". Setting it to en doesn't change anything. My system locale is en_US.UTF-8.

I'm electing to "fix" this by downgrading to 0.14.1 instead.

Step to reproduce

I believe this issue was actually demonstrated in #1634, but that was a multi-lingual site so it was diagnosed as a docs issue. If you take that site and switch the default language and/or remove the translation and default language, it repros on 0.15.0.

@cbiffle
Copy link
Contributor Author

cbiffle commented Dec 7, 2021

Oh, config.generate_feed also doesn't appear to make it through to templates in 0.15.0, interestingly.

@Keats Keats added the bug label Dec 7, 2021
@Keats
Copy link
Collaborator

Keats commented Dec 7, 2021

That's a big one!

@cbiffle
Copy link
Contributor Author

cbiffle commented Dec 7, 2021

This is not the first time a Zola update has hosed my templates. What's the regression test process for a release look like?

Keats added a commit that referenced this issue Dec 7, 2021
@Keats
Copy link
Collaborator

Keats commented Dec 7, 2021

What's the regression test process for a release look like?

Mostly me running it on the docs and various people trying the next branch + tests. There are not enough integration tests right now and I'd like 0.16 to be focused on refactoring + testing.

The issue should be fixed in the next branch.

@swaits
Copy link

swaits commented Dec 8, 2021

Will you push a new release for this, please?

@cbiffle
Copy link
Contributor Author

cbiffle commented Dec 8, 2021

What's the regression test process for a release look like?

Mostly me running it on the docs and various people trying the next branch + tests. There are not enough integration tests right now and I'd like 0.16 to be focused on refactoring + testing.

The issue should be fixed in the next branch.

Good to know. I'll switch away from using my distro's package then, since Arch doesn't support partial up/downgrades and it seems I need to go through a manual testing process before changing Zola versions.

Thanks for the quick fix.

Edit: ...huh, zola does not appear to be on crates.io and is thus not available for cargo install. Is that deliberate?

@Keats
Copy link
Collaborator

Keats commented Dec 8, 2021

I'll do a release later today.

Is that deliberate?

Yes.

@Keats Keats closed this as completed in 7ce4f75 Dec 8, 2021
thomasantony pushed a commit to thomasantony/zola that referenced this issue Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants