WIP: Refactor markdown #174
Conversation
| parser: Peekable<Parser<'b>>, | ||
| } | ||
|
|
||
| fn is_internal_link(link: &str) -> bool { |
There was a problem hiding this comment.
this is only used once so I don't think it needs to be a function
There was a problem hiding this comment.
Yes, it's only used once, but I think the value here is being explicit about what the parsing is looking for. When simply using link.starts_with("./") I think it's not as apparent that what we're really looking for is an internal link.
| fn new(context: &'a Context<'a>, parser: Parser<'b>, errors: &'c mut Vec<Error>) -> GutenbergFlavoredMarkdownParser<'a, 'b, 'c> { | ||
| GutenbergFlavoredMarkdownParser { | ||
| context: context, | ||
| errors: errors, |
There was a problem hiding this comment.
no need to repeat context and errors, {context, errors, parser: parser.peekable()} will work
There was a problem hiding this comment.
whoa! I had no idea! that's awesome
| self.empty_event() | ||
| } | ||
| } | ||
| } else{ |
| } | ||
| } | ||
| } else{ | ||
| Event::Start(Tag::Link(href.clone(), text.clone())) |
There was a problem hiding this comment.
not possible to return the link without cloning?
There was a problem hiding this comment.
The current implementation clones as well, so we just left it while it's still a WIP, but we'll go back at the end and clean up as many clones as possible.
| } | ||
| } | ||
|
|
||
| #[allow(unused_variables)] |
There was a problem hiding this comment.
is that just while it's a wip?
There was a problem hiding this comment.
yes, to make fewer warnings. We'll make sure to remove these and fix warnings before finally submitting.
|
Ah can you do the PR on the |
|
I'm guessing this PR can be redone from scratch with the coming changes to the shortcode handling? Or at least significant changes |
|
Closing this for now, since we're going to regroup a bit on our approach. We'll open a new PR once we've rebased against the next branch. |
Here's our start at rewriting the markdown extension as proposed in #160. Feedback or suggestions are welcome!