Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove string manipulation of paths #1941

Merged
merged 2 commits into from
Jul 25, 2022
Merged

remove string manipulation of paths #1941

merged 2 commits into from
Jul 25, 2022

Conversation

swiftcoder
Copy link
Contributor

@swiftcoder swiftcoder commented Jul 25, 2022 •
edited
Loading

The string manipulation here breaks canonical Windows file paths, so use the path API directly instead.

Fixes #1939

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

Keats and others added 2 commits July 25, 2022 14:14
@Keats
Add docs for backlinks
15a523b
@swiftcoder
remove string manipulation of paths
30c36c4 
The string manipulation here breaks canonical Windows file paths, so use the path API directly instead.
@Keats Keats changed the base branch from master to next July 25, 2022 18:22
@Keats Keats merged commit 187ce20 into getzola:next Jul 25, 2022
@Keats
Copy link
Collaborator

Keats commented Jul 25, 2022

Thanks! Not sure why this was there

@swiftcoder swiftcoder deleted the windows_paths branch July 25, 2022 18:42
@swiftcoder swiftcoder mentioned this pull request Jul 25, 2022
Closed
@tollyx tollyx mentioned this pull request Jul 25, 2022
Closed
Keats pushed a commit that referenced this pull request Aug 7, 2022
@swiftcoder @Keats
remove string manipulation of paths (#1941)
d32edb0 
* remove string manipulation of paths
@nyanpasu64 nyanpasu64 mentioned this pull request Aug 13, 2022
Open
Keats pushed a commit that referenced this pull request Aug 14, 2022
@swiftcoder @Keats
remove string manipulation of paths (#1941)
93d61cd 
* remove string manipulation of paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in library::content::page::Page::serialize_assets on Windows
2 participants
@swiftcoder @Keats