Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new flag 'no-port-append' to give the ability to remove port from base url #2003

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

ffrizzo
Copy link
Contributor

@ffrizzo ffrizzo commented Oct 14, 2022

IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.

The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

@ProximaB
Copy link

ProximaB commented Oct 14, 2022

Sorry if I mislead you with the typo in my issue. The name of the flag should rather be ‘ appendPort’. That would be the same as in Hugo. Thanks for your PR.

@ffrizzo ffrizzo changed the title Add new flag 'port_append' to give the ability to remove port from base url Add new flag 'append-port' to give the ability to remove port from base url Oct 14, 2022
@ffrizzo ffrizzo marked this pull request as ready for review October 14, 2022 16:18
@ffrizzo ffrizzo force-pushed the append-port branch 2 times, most recently from 043dcb7 to d2783f6 Compare October 17, 2022 14:09
@ffrizzo ffrizzo changed the title Add new flag 'append-port' to give the ability to remove port from base url Add new flag 'no-port-append' to give the ability to remove port from base url Oct 18, 2022
@ProximaB
Copy link

ProximaB commented Oct 18, 2022

Does anyone know what is the cause of this failed test? That change of the behavior is unexpected.

---- can_render_basic_markdown stdout ----
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Differences ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file: components/markdown/tests/snapshots/markdown__can_render_basic_markdown.snap
Snapshot: can_render_basic_markdown
Source: components/markdown/tests/markdown.rs:27
────────────────────────────────────────────────────────────────────────────────
Expression: body
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    2     2 │ <p>Hello <em>world</em>
    3     3 │ Hello
    4     4 │ world
    5     5 │ Non rendered emoji :smile:
    6       │-<a href="image.jpg">a link</a>
          6 │+<a href="[https://www.getzola.org/test/image.jpg">a](https://www.getzola.org/test/image.jpg%22%3Ea) link</a>
    7     7 │ <img src="[https://www.getzola.org/test/image.jpg"](https://www.getzola.org/test/image.jpg%22) alt="alt text" /></p>
    8     8 │ <h1>some html</h1>
` ``

@Keats
Copy link
Collaborator

Keats commented Oct 18, 2022

It should be fixed if you rebase

@ProximaB
Copy link

I thought I did test that here #2007

@Keats
Copy link
Collaborator

Keats commented Oct 18, 2022 via email

@ProximaB
Copy link

@Keats Hello, any updates about that?

@Keats Keats merged commit 94a594b into getzola:next Oct 25, 2022
@ffrizzo ffrizzo deleted the append-port branch October 25, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants