Xrun should also build the app #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is obvious in hindsight, but instead of forcing users to build manually and then run as a separate step we should instead build _and_ run when the user invokes `Xrun`. This _greatly_ simplifies the UI and is much more intuitive. Note that this meant refactoring the commands so that we're always passing the preferred simulator from the top down. For _most_ of the commands, it doesn't really matter, but for `Xrun` we want to make sure that we're building and running with the same settings consistently.
|
👍 on this change, seems like the right thing to do. At some point it might be worth adding some "build without running thing" which I have started using quite often to reset the run state during debugging sessions. But this should definitely be the main command. |
|
@keith you mean run without building? |
|
Haha yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is obvious in hindsight, but instead of forcing users to build manually
and then run as a separate step we should instead build and run when the
user invokes
Xrun. This greatly simplifies the UI and is much moreintuitive.
Note that this meant refactoring the commands so that we're always passing the
preferred simulator from the top down. For most of the commands, it doesn't
really matter, but for
Xrunwe want to make sure that we're building andrunning with the same settings consistently.
Fixes #68