Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where device builds would be installed in the simulator #71

Closed
wants to merge 3 commits into from
Closed

Fix issue where device builds would be installed in the simulator #71

wants to merge 3 commits into from

Commits on Jul 15, 2016

  1. Use CONFIGURATION_BUILD_DIR when searching for iOS app to install 

    BUILD_DIR has multiple subfolders for different configuration/sdk
combinations, which can result in an app being installed for the wrong
architecture (e.g., a Debug-iphoneos build instead of Debug-iphonesimulator).
    @sharplet
    sharplet committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    df3bab1 View commit details
    Browse the repository at this point in the history

  2. Add support for setting a custom build configuration 

    Previously we used Xcode's defaults for build configuration, which are
determined using a combination of project settings and scheme action
configuration. However, `xcodebuild -showBuildSettings` doesn't resolve
build settings the same way it does when actually performing a build
action, giving unexpected results when attempting to locate the correct
build directory for running.

Adding support for a configurable, explicit build configuration works
around this problem, while also allowing users to build/test/run in
Release configuration or a custom configuration.
    @sharplet
    sharplet committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    c63791e View commit details
    Browse the repository at this point in the history

  3. Explicitly pass sdk flag when running in the iOS simulator 

    Without the SDK set explicitly, `xcodebuild -showBuildSettings` defaults
to `-iphoneos` for CONFIGURATION_BUILD_DIR. Passing through the
destination unfortunately has no effect.
    @sharplet
    sharplet committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    1c0faa7 View commit details
    Browse the repository at this point in the history