Replace cgmath bindings by mint
#1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User needs manually set `mint` feature in his dependencies if he wants to use mint types in constant buffers and/or uniforms for shaders.
Now supports both column-major and row-major matrices.
kvark
requested changes
Jun 10, 2017
src/core/Cargo.toml
Outdated
| @@ -29,14 +29,13 @@ path = "src/lib.rs" | |||
|
|
|||
| [dependencies] | |||
| bitflags = "0.8" | |||
| cgmath = { version = "0.14", optional = true } | |||
| mint = { version = "0.3", optional = true } | |||
src/core/src/shade.rs
Outdated
| use cgmath::{Deg, Matrix2, Matrix3, Matrix4, Point2, Point3, Rad, Vector2, Vector3, Vector4}; | ||
| #[cfg(feature = "mint")] | ||
| use mint::{ | ||
| Point2, Point3, |
There was a problem hiding this comment.
I don't think it makes sense to use all the types explicitly as opposed to a simple use mint;, given that all the usage is in macros, so there are no ergonomics concerns
src/render/Cargo.toml
Outdated
| serialize = ["gfx_core/serialize", "draw_state/serialize"] | ||
| unstable = [] | ||
|
|
||
| [dependencies] | ||
| cgmath = { version = "0.14", optional = true } | ||
| mint = { version = "0.3", optional = true } |
src/render/src/shade.rs
Outdated
| use cgmath::{Deg, Matrix2, Matrix3, Matrix4, Rad, Point2, Point3, Vector2, Vector3, Vector4}; | ||
| #[cfg(feature = "mint")] | ||
| use mint::{ | ||
| Point2, Point3, |
There was a problem hiding this comment.
similarly, please just do use mint
|
Appveyor nightly fails because of rust-lang/rust#42544 |
|
Wonderful, thank you! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1290
Unfortunately (or maybe not),
RadandDegtypes were removed.