Migrate device methods to align with webgpu-headers #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 20, 2021 12:36
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is an autogenerated code review.
Checker summary (by rust_clippy):
The tool has found 21 warnings, 0 errors.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
kvark
reviewed
Feb 22, 2021
| #[repr(C)] | ||
| pub struct CDeviceDescriptor { | ||
| pub struct CDeviceDescriptor<'c> { |
There was a problem hiding this comment.
do we really need the C prefixes for these types? They are not colliding with wgt::DeviceDescriptor, since we aren't glob-importing wgt, so we could call them the same.
There was a problem hiding this comment.
See also - #78 as a radical solution to this
|
Closing as in favor of building off of the excellent work done in #85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second patch to align wgpu-native with webgpu-headers. This time focusing on the
wgpuDevice*functions.Largest change was to
wgpuDeviceCreateBindGroupLayoutwhich has been rebuilt to use the*BindingLayoutstructs.Also wgpuDeviceCreateShaderModule now uses
follow_chain!macro.