v0.13 - BrowserWebGpu - AutoNoVSync does not properly fallback

[simbleau]

Description
AutoNoVSync appears to not fall-back correctly.

Repro steps
https://github.com/simbleau/nbody-wasm-sim/tree/4cd3b2fadb0bed6b71ef3253f3989d78fd5d2020
wasm-pack build --target web
python -m http.server
http://localhost:8000/

Expected vs observed behavior
Error stack forwarded to the console via WASM:
panicked at 'Error in Surface::configure: requested present mode AutoNoVsync is not in the list of supported present modes: [Fifo]'

This seems like a bug because the AutoNoVSync documentation says it will fallback to Fifo, but clear it is not, and detects Fifo as a supported present mode.

Extra materials

Platform
wgpu 0.13
linux, ubuntu 20.04 LTS

[seabassjh]

I also get this bug.

Platform
wgpu 0.13
Windows 11

[cwfitzgerald]

D'oh, easy fix - I'll fix it and launch a backport

[simbleau]

I can do the PR as well if you want. :)
Haven't contributed yet and I wouldn't mind.

[cwfitzgerald]

Sorry didn't reply fast enough, I wanted to refactor bit of code a bit too - but let's merge your change first, then I'll merge mine in so you still get credit :)

[simbleau]

Awesome! Still working on the PR/Changelog ceremony. Thanks!

[simbleau]

PR is ready.

[simbleau]

Hey, necromancing because this appears to still be an outstanding issue. I thought we fixed it, but I guess not?

[cwfitzgerald]

Is wgpu-core at 0.13.1?

[simbleau]

Yes

wgpu = { version = "0.13.1", features = ["webgl"] }

[cwfitzgerald]

That's wgpu, cargo won't update transitive dependencies unless you force it to, try cargo update -p wgpu-core -p wgpu-hal

[simbleau]

It works! Sorry for the necromancing. :P

[cwfitzgerald]

All good!

[simbleau]

Yes Thank you, Spencer C. Imbleau (he/him/his) (https://www.glsen.org/pronouns) Software Engineer II NASA, Kennedy Space Center ***@***.*** ***@***.***) | +1 (704) 747-5126 (tel:+1-704-747-5126)

…

On Jul 3 2022, at 4:04 pm, Connor Fitzgerald ***@***.***> wrote: Is wgpu-core at 0.13.1? — Reply to this email directly, view it on GitHub (#2840 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/ALPBK5JYK6ETRJPXU2CSLSDVSHW5RANCNFSM52P2JCRQ). You are receiving this because you authored the thread.