Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change AdapterInfo::{device,vendor} to be u32 instead of usize #3759

Closed
ErichDonGubler opened this issue May 8, 2023 · 1 comment · Fixed by #3760
Closed

Change AdapterInfo::{device,vendor} to be u32 instead of usize #3759

ErichDonGubler opened this issue May 8, 2023 · 1 comment · Fixed by #3760
Labels
area: api Issues related to API surface good first issue Good for newcomers help required We need community help to make this happen. type: enhancement New feature or request

Comments

@ErichDonGubler
Copy link
Member

Description

The highest integer width of any platform supported by wgpu is fixed. It's also generally not a good idea to rely on platform-specific word sizes for cross-platform fields. Therefore, we should change [AdapterInfo]'s device and vendor fields (which correspond to either u16 PCI IDs or u32 Vulkan IDs) to be u32s.

Matrix discussion prompting this issue.

Later, we might examine making this more strongly typed (see this discussion in Matrix).
@ErichDonGubler
Copy link
Member Author

This should be an easy issue for new contributors to help out with. I can't change labels, or I'd do it myself. 😖

@cwfitzgerald cwfitzgerald added type: enhancement New feature or request help required We need community help to make this happen. good first issue Good for newcomers area: api Issues related to API surface labels May 8, 2023
@ameknite ameknite mentioned this issue May 9, 2023
Merged
3 tasks
@ErichDonGubler ErichDonGubler mentioned this issue May 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api Issues related to API surface good first issue Good for newcomers help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change AdapterInfo::{device,vendor} fields to u32
2 participants
@ErichDonGubler @cwfitzgerald