Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change AdapterInfo::{device,vendor} fields to u32 #3760

Merged
merged 2 commits into from
May 9, 2023
Merged

Change AdapterInfo::{device,vendor} fields to u32 #3760

merged 2 commits into from
May 9, 2023

Conversation

ameknite
Copy link
Contributor

@ameknite ameknite commented May 9, 2023 •
edited
Loading

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Fix #3759

Wumpf
Wumpf approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

teoxoy
teoxoy approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@teoxoy teoxoy merged commit 4d8a7ed into gfx-rs:trunk May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change AdapterInfo::{device,vendor} to be u32 instead of usize
3 participants
@ameknite @Wumpf @teoxoy