Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create array layer trackers for 3D textures. #2348

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Don't create array layer trackers for 3D textures. #2348

merged 1 commit into from
Jan 3, 2022

Conversation

ElectronicRU
Copy link
Contributor

Connections
Fixes #2347

Description
Avoids a bunch of extra erroneous clears for array layers for 3D image.

@ElectronicRU
Copy link
Contributor Author

@kvark as the one who reviewed #1688 I think you should take a look. This looks correct to me, but I'm not 100% positive.

kvark
kvark approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@kvark kvark merged commit 43f09fd into gfx-rs:master Jan 3, 2022
@kvark kvark added the PR: needs back-porting PR with a fix that needs to land on crates label Jan 3, 2022
@kvark kvark mentioned this pull request Jan 10, 2022
Merged
@kvark
Copy link
Member

kvark commented Jan 10, 2022

published in wgpu-core-0.12.2

@kvark kvark removed the PR: needs back-porting PR with a fix that needs to land on crates label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wgpu-core: TextureClearRange does, in fact, track volume slices separately
2 participants
@ElectronicRU @kvark