Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add util::indirect::* helper structs #2365

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

IcanDivideBy0
Copy link
Contributor

@IcanDivideBy0 IcanDivideBy0 commented Jan 7, 2022

Connections
n/a

Description
I think most people using indirect draw calls will end up rewriting those structs just as they are described in the doc, make it simpler to have them implemented right here

Testing
tested locally, works as expected

wgpu/src/util/indirect.rs Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Would you mind adding DispatchIndirect as well?

@IcanDivideBy0
Copy link
Contributor Author

Looks great. Would you mind adding DispatchIndirect as well?

sure, i've added it

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@kvark kvark enabled auto-merge (rebase) January 7, 2022 16:31
@IcanDivideBy0 IcanDivideBy0 changed the title Add DrawIndirect & DrawIndexedIndirect structs Add utils::indirect::* helper structs Jan 7, 2022
@IcanDivideBy0 IcanDivideBy0 changed the title Add utils::indirect::* helper structs Add util::indirect::* helper structs Jan 7, 2022
@kvark kvark merged commit e924aa1 into gfx-rs:master Jan 7, 2022
@IcanDivideBy0 IcanDivideBy0 deleted the indirect_util branch January 7, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants