Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix msaa-line example's unnecessary MSAA data store #2421

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Fix msaa-line example's unnecessary MSAA data store #2421

merged 1 commit into from
Jan 25, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Jan 25, 2022

Description
Storing pre-resolve MSAA data is unnecessary if it isn't used later. On tile-based GPU, avoid store can reduce app's memory footprint.

Testing
Tested on M1 macOS, Android 8.1 && 10.0 Phones(both GL and VULKAN backend), iPhone 12

Addition info

Debugging msaa-line example on macOS:

warning message:Storing pre-resolve MSAA data is unnecessary if it isn't used later. 
macOS
	
Debugging on iPhone:

warning message:Storing pre-resolve MSAA data is unnecessary if it isn't used later. 
It increases your app's memory footprint and can be avoided by using memoryless textures.
iPhone
	

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kvark kvark merged commit 77b2c25 into gfx-rs:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants