metal: improve push | pop_debug_marker
#2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Mar 15, 2022
|
Great work, thank you! |
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 25, 2023
Restore `negative_index` test in `tests/wgsl-errors.rs`, as part of the `invalid_arrays` test function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Invoking
push | pop_debug_marker,entry_anymay create empty blit command encoder, which results in warnings and incorrectdebug_grouphierarchy relationships:`Blit Encoder "Oxxxx" has no work encoded to it` (Issue) Your app created an encoder that had no work encoded to it. Creating an empty encoder causes unnecessary CPU overhead and potentiallv bandwidth usage.Testing
Tested boids example on macOS and iOS: