Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate 1x1 mip level #2551

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Generate 1x1 mip level #2551

merged 1 commit into from
Mar 24, 2022

Conversation

davidar
Copy link
Contributor

@davidar davidar commented Mar 23, 2022

Just a minor off-by-one error that meant the final 1x1 mip level wasn't being generated. I don't think it makes any substantial difference to the rendered result.

Just a minor off-by-one error that meant the final 1x1 mip level wasn't being generated. I don't think it makes any substantial difference to the rendered result.
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one comment

wgpu/examples/mipmap/main.rs Show resolved Hide resolved
@cwfitzgerald cwfitzgerald merged commit 46eea16 into gfx-rs:master Mar 24, 2022
@davidar davidar deleted the patch-1 branch March 24, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants