Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose vulkan physical device capabilities, enabled device extensions #2688

Merged
merged 1 commit into from
Jun 10, 2022
Merged

expose vulkan physical device capabilities, enabled device extensions #2688

merged 1 commit into from
Jun 10, 2022

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented May 22, 2022 •
edited
Loading

Description
Well this pull request expanded a bit as you can see in the edits.

  • Expose physical device properties and PhysicalDeviceCapabilities from Vulkan's Adapter
  • For Vulkan's Device, expose the following
    • Enabled device extensions
    • Raw physical device (needed for getting data associated with a device that is too varied to calculate at creation time).
    • The instance the device is from (for getting said physical device data)
    • Version of the instance on the device (For above)
    • Enabled instance extensions (Also for above)
  • For Vulkan's Adapter, expose the following
    • The instance
    • The version of the instance
    • Enabled instance extensions

@i509VCB i509VCB changed the title expose vulkan physical device capabilities expose vulkan physical device capabilities, enabled device extensions May 22, 2022
@i509VCB i509VCB force-pushed the hal/vk-phd-props branch 3 times, most recently from 22008a3 to 68f4a01 Compare May 29, 2022 04:06
cwfitzgerald
cwfitzgerald requested changes May 29, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baring one comment, I think this is fine. My only question is more design focused, should we be exposing things like this or should we be making the fields public, which would potentially allow creating wgpu-hal types from the raw vulkan stuff.

wgpu-hal/src/vulkan/device.rs Outdated Show resolved Hide resolved
@i509VCB i509VCB requested a review from cwfitzgerald May 30, 2022 01:15
cwfitzgerald
cwfitzgerald approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM

@cwfitzgerald cwfitzgerald merged commit e0327b1 into gfx-rs:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i509VCB @cwfitzgerald