Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Fixes #2862
Description
The
as_hal
family of functions will invoke the callback withNone
if the wrong api is used as the generic type. This is because theHalApi
generic performs lookup in a different hub. However theget
function in the storage will fail if the id used for lookup is not in the storage (because you specified the wrong generic type) and therefore panic.To solve this, a
try_get
function is used for allas_hal
functions to ensure thatas_hal
will actually returnNone
instead of panicking.