Implement "strict_asserts" feature in wgpu-core. #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
tracker_asserts
branch
from
aa79dea
to
fde61d6
Compare
jimblandy
force-pushed
the
tracker_asserts
branch
from
fde61d6
to
c1d50f1
Compare
cwfitzgerald
requested changes
Jul 13, 2022
jimblandy
force-pushed
the
tracker_asserts
branch
from
c1d50f1
to
15177b2
Compare
cwfitzgerald
requested changes
Aug 4, 2022
Since `wgpu-core`'s public functions are supposed to validate their parameters, the internal `track` module skips many of Rust's usual run-time checks in release builds. However, some `wgpu-core` users are happy to pay the performance cost in exchange for more safety. The `"strict_asserts"` feature causes `wgpu_core` to perform the same checks in release builds as it does in debug builds.
jimblandy
force-pushed
the
tracker_asserts
branch
from
15177b2
to
0ed4a43
Compare
|
I changed the name of the feature and macros to 'strict_assert'. |
jimblandy
changed the title
cwfitzgerald
approved these changes
Aug 8, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
wgpu-core's public functions are supposed to validate theirparameters, the internal
trackmodule skips many of Rust's usualrun-time checks in release builds. However, some
wgpu-coreusersare happy to pay the performance cost in exchange for more safety.
The
"tracker_asserts"feature causes thetrackmodule to performthe same checks in release builds as it does in debug builds.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.