use smallvec instead of inplace_it #2889
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Description
Remove
inplace_it
to usesmallvec
instead. Whileinlace_it
tries to be clever with the size of the array used, I just set it to 32 insmallvec
On latest nightly,
inplace_it
fails to compile. This will probably be fixed on Rust (rust-lang/rust#99288) orinplace_it
(NotIntMan/inplace_it#11), butinplace_it
hasn't been updated in a while.Testing
This is Vulkan only change and I don't have a Vulkan capable machine, so not tested a lot...