Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metal: remove PrivateCapabilities's format_rgb10a2_unorm_surface field #2981

Merged
merged 2 commits into from
Sep 3, 2022

Conversation

jinleili
Copy link
Contributor

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description

Rgb10a2Unorm is supported above AppleGPUFamily 2, not only macOS. Can use the existing format_rgb10a2_unorm_all field instead of format_rgb10a2_unorm_surface.
截屏2022-08-23 20 22 15

Testing
Tested on macOS and iOS

@jimblandy
Copy link
Member

@jinleili If you could add a CHANGELOG.md entry and rebase, we should be able to get a clean CI run from this now.

@jimblandy jimblandy merged commit e350f50 into gfx-rs:master Sep 3, 2022
@jinleili jinleili deleted the mtl_wcg branch September 3, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants