-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve compute shader validation error message #3139
Improve compute shader validation error message #3139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Suggested some alternative wording to help make the error message even more clear.
Co-authored-by: Connor Fitzgerald <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3139 +/- ##
===========================================
+ Coverage 1.34% 64.76% +63.42%
===========================================
Files 70 81 +11
Lines 18683 38764 +20081
===========================================
+ Hits 251 25106 +24855
+ Misses 18432 13658 -4774
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Potential improvement for #2985
Description
The previous error message was easily misunderstood, as it didn't say explicitly that each dimension and the total number must be below the bounds.
For example, instead of:
after applying this PR the error is:
Thanks to @mwalczyk for the original improvement idea 🙏
Testing
In
shader.wgsl
of thehello-compute
example, I've changed the@workgroup_size(1)
to@workgroup_size(8, 8, 8)