Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease max_buffer_size limit value to be compatible with Apple2 GPU #3255

Merged
merged 3 commits into from
Dec 3, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Dec 3, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
From matrix: max_buffer_size: 1<<30 is larger than Apple2 GPU's limits

Description

Testing
Tested locally on Apple2 GPU device (iPhone 6)

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Merging #3255 (291d732) into master (88acaf7) will decrease coverage by 18.46%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #3255       +/-   ##
===========================================
- Coverage   65.60%   47.13%   -18.47%     
===========================================
  Files          82       82               
  Lines       39468    39439       -29     
===========================================
- Hits        25894    18591     -7303     
- Misses      13574    20848     +7274     
Impacted Files Coverage Δ
wgpu-types/src/lib.rs 85.51% <100.00%> (-2.62%) ⬇️
wgpu-hal/src/gles/device.rs 0.00% <0.00%> (-80.19%) ⬇️
wgpu-hal/src/vulkan/adapter.rs 0.00% <0.00%> (-77.52%) ⬇️
wgpu-hal/src/vulkan/device.rs 0.00% <0.00%> (-75.42%) ⬇️
wgpu-hal/src/gles/conv.rs 0.00% <0.00%> (-74.36%) ⬇️
wgpu-hal/src/gles/adapter.rs 9.70% <0.00%> (-73.90%) ⬇️
wgpu-hal/src/vulkan/conv.rs 1.11% <0.00%> (-70.66%) ⬇️
wgpu-hal/src/gles/command.rs 0.00% <0.00%> (-69.83%) ⬇️
wgpu-hal/src/vulkan/command.rs 0.92% <0.00%> (-67.42%) ⬇️
wgpu-hal/src/gles/mod.rs 0.00% <0.00%> (-61.54%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwfitzgerald
Copy link
Member

For reference, this is the value in the spec too.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an implicit change, so should likely be front and center in the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) December 3, 2022 08:05
@cwfitzgerald cwfitzgerald merged commit 5f3acf5 into gfx-rs:master Dec 3, 2022
@jinleili jinleili deleted the limits branch December 7, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants