Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ash 0.37.1 to replace deprecated function call #3273

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

Elabajaba
Copy link
Contributor

@Elabajaba Elabajaba commented Dec 8, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description
CI was breaking for me in #3163 after running cargo update due to debug_utils_set_object_name() being deprecated and replaced with set_debug_utils_object_name()

@codecov-commenter
Copy link

Codecov Report

Merging #3273 (57430bd) into master (a50836e) will increase coverage by 1.05%.
The diff coverage is 100.00%.

❗ Current head 57430bd differs from pull request most recent head f08fbab. Consider uploading reports for the commit f08fbab to get more accurate results

@@            Coverage Diff             @@
##           master    #3273      +/-   ##
==========================================
+ Coverage   64.99%   66.05%   +1.05%     
==========================================
  Files          82       64      -18     
  Lines       39474    34307    -5167     
==========================================
- Hits        25658    22663    -2995     
+ Misses      13816    11644    -2172     
Impacted Files Coverage Δ
wgpu-hal/src/vulkan/device.rs 75.41% <100.00%> (ø)
wgpu-hal/src/auxil/renderdoc.rs 40.50% <0.00%> (-3.55%) ⬇️
wgpu-hal/src/lib.rs 23.30% <0.00%> (-2.92%) ⬇️
wgpu-hal/src/gles/egl.rs 38.00% <0.00%> (-0.50%) ⬇️
wgpu-types/src/lib.rs 87.64% <0.00%> (-0.48%) ⬇️
wgpu-core/src/device/mod.rs 66.53% <0.00%> (-0.20%) ⬇️
wgpu-hal/src/vulkan/instance.rs 37.41% <0.00%> (-0.20%) ⬇️
wgpu-core/src/validation.rs 58.87% <0.00%> (-0.14%) ⬇️
wgpu-hal/src/dx12/view.rs
wgpu-hal/src/dx12/conv.rs
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus nit

Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: Connor Fitzgerald <[email protected]>
@cwfitzgerald cwfitzgerald merged commit 85fda2d into gfx-rs:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants