-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document and improve extension detection #3327
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3327 +/- ##
==========================================
+ Coverage 64.10% 65.09% +0.99%
==========================================
Files 86 86
Lines 42591 42874 +283
==========================================
+ Hits 27301 27910 +609
+ Misses 15290 14964 -326
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my machine - g2g after nit
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Description
We used to require
VK_EXT_sampler_filter_minmax
and never used it.We used to require
VK_KHR_maintenance2
andVK_KHR_timeline_semaphore
unconditionally.We never required
VK_EXT_image_robustness
andVK_EXT_robustness2
(if available).We weren't building
PhysicalDeviceDescriptorIndexingFeaturesEXT
for Vulkan 1.2+.We weren't building
GetPhysicalDeviceProperties2
for Vulkan 1.0, this in turn making some features unusable.Testing