Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-filtering integer texture sampling #3362

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Jan 8, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Description
Allow using textureGather on integer textures, by allowing non-filtered integer texture sampling.

Testing
Ran my bevy fork with this patch applied. Modify bevy/Cargo.toml to patch wgpu/naga, then run cargo run --example ssao.

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2023

Codecov Report

Merging #3362 (5088134) into master (a06ef71) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #3362      +/-   ##
==========================================
- Coverage   64.49%   64.49%   -0.01%     
==========================================
  Files          86       86              
  Lines       42696    42697       +1     
==========================================
  Hits        27537    27537              
- Misses      15159    15160       +1     
Impacted Files Coverage Δ
wgpu-core/src/validation.rs 58.93% <60.00%> (+0.05%) ⬆️
wgpu-core/src/hub.rs 60.67% <0.00%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@teoxoy teoxoy merged commit ad4dac8 into gfx-rs:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integer textures can't be sampled
3 participants