Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): don't panic on mapped buffer in queue_submit #3364

Merged
merged 3 commits into from
Jan 15, 2023

Conversation

crowlKats
Copy link
Collaborator

Reported in denoland/deno#10098

Copy link
Contributor

@nical nical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nical
Copy link
Contributor

nical commented Jan 10, 2023

This is just missing a changelog entry.

@codecov-commenter
Copy link

Codecov Report

Merging #3364 (bf4ac7b) into master (fac4731) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #3364   +/-   ##
=======================================
  Coverage   65.22%   65.23%           
=======================================
  Files          86       86           
  Lines       42724    42724           
=======================================
+ Hits        27867    27869    +2     
+ Misses      14857    14855    -2     
Impacted Files Coverage Δ
wgpu-core/src/device/queue.rs 70.25% <0.00%> (ø)
wgpu-core/src/device/mod.rs 66.74% <0.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@crowlKats crowlKats merged commit f40611f into gfx-rs:master Jan 15, 2023
@crowlKats crowlKats deleted the mapped_buffer_dont_panic branch January 15, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants