Create gles buffers with DYNAMIC_DRAW instead of STATIC_DRAW #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
force-pushed
the
gl_buffer_usage
branch
from
26f6309
to
676db0a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3391 +/- ##
==========================================
+ Coverage 64.70% 65.22% +0.51%
==========================================
Files 66 86 +20
Lines 37336 42725 +5389
==========================================
+ Hits 24159 27868 +3709
- Misses 13177 14857 +1680
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Dinnerbone
force-pushed
the
gl_buffer_usage
branch
from
676db0a
to
2265209
Compare
nical
approved these changes
Jan 17, 2023
|
Very nicely done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
This fixes #3371.
Description
wgpu currently creates buffers with
STATIC_DRAW, but it actually updates the buffer once after creation to copy in the data from a staging buffer.Some vendors take this usage hint literally, and freeze the buffer at the data it was created with - leaving it empty and unusable.
In an ideal world we'd be able to populate the data here in the constructor and keep it
STATIC_DRAWfor all butBufferUsage::COPY_DST, perhaps using a specialized path fromcreate_buffer_init, but we don't live in that ideal world right now and have to pay the penalty ofDYNAMIC_DRAW.Testing
It passes all of the existing tests, and is confirmed to fix #3371 on affected devices.