Remove backend_bits from initialize_adapter_from_env #3904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy
.cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
#3792, initialize_adapter_from_env_or_default ignores backend_bits if WGPU_ADAPTER_NAME is not set
Description
As described in #3792, the
initialize_adapter_from_env_or_default
function currently ignoresbackend_bits
ifWGPU_ADAPTER_NAME
is not set.Instead of going towards the path of making these utility functions more complex (or adding e.g.
backend_bits
toRequestAdapterOptions
), let's perhaps removebackend_bits
from these functions completely, in favour of usingInstanceDescriptor::backends
? So instead ofthe recommended way would be:
What do you think?
Testing
By existing tests, or a utility program such as listed above.