Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace logging adjustments #4188

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Trace logging adjustments #4188

merged 1 commit into from
Oct 2, 2023

Conversation

nical
Copy link
Contributor

@nical nical commented Sep 29, 2023

Checklist

  • Run cargo clippy.

Connections

Followup from #4183

Description

This makes a few adjustments to the logging, mainly:

  • Log ids in the form Id<T> rather than Valid<Id<T>> in a few places.
  • Move logging related to the command encoder to where it is replayed instead of where it is recorded, otherwise the logging does not happen when replaying a wgpu trace.

@nical nical requested a review from a team as a code owner September 29, 2023 13:16
@nical nical merged commit 9ff61fe into gfx-rs:trunk Oct 2, 2023
20 checks passed
@nical nical deleted the log branch October 2, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nical @ErichDonGubler