-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump raw window handle to 0.6.0 #4202
Bump raw window handle to 0.6.0 #4202
Conversation
PR title says 6.0.0 which is a typo. |
whoops, sorry! Thank you for pointing it out |
Winit dependency is in: |
Aye! Will continue this PR! |
Welp... so the only test which is failing is from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
Checklist
cargo clippy
.cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
This PR tries to fix the code of #4193
Description
raw-window-handle
from0.5
->0.6
CreateSurfaceErrorKind
:CreateSurfaceErrorKind::RawHandle(raw_window_handle::HandleError)
which holds the error when trying to get the an handler for aWindow
or aDisplay
.Testing
TODO
Status
We have to wait for rust-windowing/winit#3126 because
winit
hasn't bumpedraw-window-handle
yet, hence I'm getting the following error messages for example: