Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sRGB and linear blending example #4275

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Oct 22, 2023

This tests if sRGB and linear framebuffers are working as expected.

@Zoxc Zoxc requested a review from a team as a code owner October 22, 2023 00:09
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only real question is if this should be an example or just a test. I think this is fine as is if you feel strongly, just throwing that possibility out there.

examples/srgb-blend/src/main.rs Show resolved Hide resolved
examples/common/src/framework.rs Show resolved Hide resolved
@Zoxc
Copy link
Contributor Author

Zoxc commented Oct 23, 2023

It's kind of a test, but you need to be able to run it outside the test framework to observe proper surface / presentation behavior.

@cwfitzgerald
Copy link
Member

Yeah fair enough

@cwfitzgerald cwfitzgerald merged commit 4b8835f into gfx-rs:trunk Oct 30, 2023
27 checks passed
@Zoxc Zoxc deleted the srgb-blend-example branch October 30, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants