Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message: "Format Bgra8UnormSrgb can't be multisampled" #4294

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Improve error message: "Format Bgra8UnormSrgb can't be multisampled" #4294

merged 4 commits into from
Oct 26, 2023

Conversation

DevJac
Copy link
Contributor

@DevJac DevJac commented Oct 24, 2023

A misleading error message was stating that "Format can't be multisampled" when using an unsupported sample count. This is misleading because often these texture formats can be multisample by using a supported sample count.

Fixes #4288

@DevJac DevJac requested a review from a team as a code owner October 24, 2023 23:34
cwfitzgerald
cwfitzgerald requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress! A bit of possible improvement.

wgpu-core/src/pipeline.rs Outdated Show resolved Hide resolved
@DevJac
Copy link
Contributor Author

DevJac commented Oct 25, 2023

I added TextureFormatFeatureFlags.supported_sample_counts and included the supported sample counts in the error messages. I also updated a 3rd error message which I was using as a pattern for my previous error message changes.

@DevJac
Copy link
Contributor Author

DevJac commented Oct 25, 2023

I included information about spec supported sample counts and device supported sample counts, as suggested. @cwfitzgerald

@DevJac
Improve error message: "Format Bgra8UnormSrgb can't be multisampled"
dd67d0c 
A misleading error message was stating that "Format can't be
multisampled" when using an unsupported sample count. This is
misleading because often these texture formats can be
multisample by using a supported sample count.
@DevJac
TextureFormatFeatureFlags.supported_sample_counts
e0e1056
@DevJac
Include supported sample counts in InvalidSampleCount errors
4bef545
@DevJac
Copy link
Contributor Author

DevJac commented Oct 26, 2023

Squashed the most recent commits.

cwfitzgerald
cwfitzgerald approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

wgpu-types/src/lib.rs Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald merged commit 6b859a1 into gfx-rs:trunk Oct 26, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing error, "Format Bgra8UnormSrgb can't be multisampled", needs better wording
2 participants
@DevJac @cwfitzgerald