Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Example Event Loop #4634

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Conversation

cwfitzgerald
Copy link
Member

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Closes #4627
Closes #4593

Description

This just completely redoes our event loop in the examples to:

  • Be comprehensible
  • Be correct

Testing

Manually

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner November 6, 2023 01:18
@cwfitzgerald cwfitzgerald changed the title Rewrite event loop Rewrite Example Event Loop Nov 6, 2023
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) November 6, 2023 01:23
@PsichiX
Copy link

PsichiX commented Nov 6, 2023

reminder for myself to test a fix with using canvas client size instead of inner size to set for canvas element size, to make canvas fill entire window area.
related conversation: https://discord.com/channels/676678179678715904/677286494033018924/1170896087020744835
notes to myself: also reproduce canvas setup of how Oxygengine does this, bc this precise combination of style worked in all and edge cases, also test scenario with canvas embedded in other elements.

@cwfitzgerald cwfitzgerald merged commit 8547226 into gfx-rs:trunk Nov 6, 2023
27 checks passed
@cwfitzgerald cwfitzgerald deleted the event-loop-fix branch November 6, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Winit Updated Caused Redraws Not to Happen hello-triangle tries to configure with zero size on web
2 participants