Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove winit from hello-compute example #4699

Merged
merged 3 commits into from
Nov 16, 2023
Merged

remove winit from hello-compute example #4699

merged 3 commits into from
Nov 16, 2023

Conversation

psvri
Copy link
Contributor

@psvri psvri commented Nov 16, 2023 •
edited
Loading

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md.

Connections
NA

Description
winit is not a required dependency to run hello compute example.

Testing
verified by checking that both the below command gave the right output

  • cargo run --bin hello-compute 1 2 3 4
  • cargo xtask --features=run-wasm run-wasm --bin hello-compute

@psvri psvri requested a review from a team as a code owner November 16, 2023 12:23
teoxoy
teoxoy approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teoxoy teoxoy enabled auto-merge (squash) November 16, 2023 13:01
@teoxoy teoxoy merged commit c12c377 into gfx-rs:trunk Nov 16, 2023
27 checks passed
@psvri psvri deleted the cleanup_1 branch November 16, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psvri @teoxoy