Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello_compute: check for missing command-line args #4939

Merged
merged 4 commits into from
Jan 2, 2024

Commits on Dec 27, 2023

  1. hello_compute: check for missing command-line args

    Fixes off-by-one error when checking for missing arguments.
    Before this, running the example gave this scary looking error message:
    
    ```
    $ cargo run --bin wgpu-examples hello_compute
        Finished dev [unoptimized + debuginfo] target(s) in 0.13s
         Running `target/debug/wgpu-examples hello_compute`
    [2023-12-27T22:14:26Z ERROR wgpu::backend::direct] Handling wgpu errors as fatal by default
    thread 'main' panicked at 'wgpu error: Validation Error
    
    Caused by:
        In Device::create_bind_group
        Buffer binding size 0 is less than minimum 4
          note: buffer = `Storage Buffer`
    
    ', wgpu/src/backend/direct.rs:3139:5
    ```
    
    As this was the first example I tried to run, it almost scared me
    away, thinking it was a driver issue.
    
    Instead, without arguments the example should use defaults.
    vilcans committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    248bbe8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    93faef2 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Configuration menu
    Copy the full SHA
    0158422 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Configuration menu
    Copy the full SHA
    e87f2d6 View commit details
    Browse the repository at this point in the history