Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the validation for vertex limits for regular render passes #5156

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

nical
Copy link
Contributor

@nical nical commented Jan 29, 2024

Connections

Similar to #5144 but for regular render passes instead of bundles.

Description

The previous validation:

  • was skipped when the vertex stride was 0,
  • did not take the "last stride" (size of the last vertex) into account.

This test fixes both problems while (unlike #5144) staying in the spirit of how the validation was implemented (presumably for performance reasons) instead of sticking to how it is described in the specification.

Testing

Covered by the CTS.

Checklist

  • Run cargo fmt.
  • Run cargo clippy.
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@nical nical requested a review from a team as a code owner January 29, 2024 09:06
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@teoxoy teoxoy merged commit 6e020a0 into gfx-rs:trunk Jan 29, 2024
27 checks passed
@nical nical deleted the vtx-validation branch January 29, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants