Allow wgpu::Instance to report which backends were enabled #5167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed_backend_features` which reports all available backends instead of just reporting if none is available.
nical
approved these changes
Jan 31, 2024
Wumpf
commented
Jan 31, 2024
waywardmonkeys
added a commit
to waywardmonkeys/wgpu
that referenced
this pull request
Feb 5, 2024
The check for macOS and Angle should add `Backends::GL` not `Backends::VULKAN`. Similarly, the comment gets updated to not refer to Vulkan. This code was introduced in gfx-rs#5167.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
In spirit related to
(but does not fix that issue)
Description
Replaces
Instance::any_backend_feature_enabledwithInstance::enabled_backend_featureswhich reports all available backends instead of just reporting if none is available.We already chugged through the very same information but didn't expose it. This is useful when a library or application wants to reason about potentially available backends based on its build configuration.
Testing
Run an example, didn't explode.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.