gles: fix crash when holding multiple devices on wayland/surfaceless. #5351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a bit of a mess with the tests, apparently the regular |
ashdnazg
force-pushed
the
feature/fix-multiple-devices
branch
2 times, most recently
from
936820d
to
3920581
Compare
Wumpf
requested changes
Mar 9, 2024
There was a problem hiding this comment.
thank you and great you added a test to catch this issue as well!
The locking logic needs another pass though I believe (see comment)
There's a bit of a mess with the tests, apparently the regular #[test] functions are not tested in the CI.
yes, all that gpu testing is a bit tricky on CI (:
ashdnazg
force-pushed
the
feature/fix-multiple-devices
branch
2 times, most recently
from
6ad6df2
to
1ac9349
Compare
ashdnazg
force-pushed
the
feature/fix-multiple-devices
branch
from
1ac9349
to
38bb236
Compare
|
Should be fixed now. |
Wumpf
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #5349
Description
See #5349 for the crash.
Unfortunately the global state of EGL forces us to do our own global state for reference counting the displays.
Testing
Added a test that crashed before and passes now.
Checklist
cargo fmt.cargo clippy.cargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.