Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BACKPORT to 0.19: fix: don't depend on BG{,L} layout entry order in HAL #5421 #5455

Merged
merged 5 commits into from
Apr 17, 2024
Merged

BACKPORT to 0.19: fix: don't depend on BG{,L} layout entry order in HAL #5421 #5455

merged 5 commits into from
Apr 17, 2024

Conversation

ErichDonGubler
Copy link
Member

Backport #5421.

@ErichDonGubler
fix(dx12): don't depend on BG{,L} entry order
f553f04 
This isn't guaranteed by `wgpu-core`; we should try to match by binding
slot index instead.
@ErichDonGubler
fix(gles): don't depend on BG{,L} entry order
7bdb145 
This isn't guaranteed by `wgpu-core`; we should try to match by binding
slot index instead.
@ErichDonGubler
fix(metal): don't depend on BG{,L} entry order
990891a 
This isn't guaranteed by `wgpu-core`; we should try to match by binding
slot index instead.
@ErichDonGubler
test: don't depend on BG{,L} entry order in HAL
b15a6c1
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner March 29, 2024 20:14
@ErichDonGubler ErichDonGubler added type: bug Something isn't working area: correctness We're behaving incorrectly api: dx12 Issues with DX12 or DXGI api: metal Issues with Metal api: gles Issues with GLES or WebGL labels Mar 29, 2024
@ErichDonGubler ErichDonGubler mentioned this pull request Mar 29, 2024
Merged
6 tasks
@ErichDonGubler ErichDonGubler changed the title BACKPORT: fix: don't depend on BG{,L} layout entry order in HAL #5421 BACKPORT to 0.19: fix: don't depend on BG{,L} layout entry order in HAL #5421 Mar 29, 2024
@ErichDonGubler
Copy link
Member Author

ErichDonGubler commented Mar 29, 2024 •
edited
Loading

Not sure what CI's deal is with shader validation (link), but I don't think it's related? 🤔

@dependabot @ErichDonGubler
build(deps): bump mio from 0.8.10 to 0.8.11
2347c13 
Bumps [mio](https://github.com/tokio-rs/mio) from 0.8.10 to 0.8.11.
- [Release notes](https://github.com/tokio-rs/mio/releases)
- [Changelog](https://github.com/tokio-rs/mio/blob/master/CHANGELOG.md)
- [Commits](tokio-rs/mio@v0.8.10...v0.8.11)

---
updated-dependencies:
- dependency-name: mio
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@ErichDonGubler
Copy link
Member Author

Just cherry-picked #5341 to resolve the cargo-deny-advisories failure in CI.

@ErichDonGubler ErichDonGubler added the PR: needs back-porting PR with a fix that needs to land on crates label Apr 15, 2024
@cwfitzgerald cwfitzgerald merged commit 95dc7e5 into gfx-rs:v0.19 Apr 17, 2024
25 of 27 checks passed
@cwfitzgerald cwfitzgerald removed the PR: needs back-porting PR with a fix that needs to land on crates label Apr 17, 2024
@ErichDonGubler ErichDonGubler deleted the create-bgl-resource-ordering-BACKPORT-0.19 branch June 7, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
api: dx12 Issues with DX12 or DXGI api: gles Issues with GLES or WebGL api: metal Issues with Metal area: correctness We're behaving incorrectly type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErichDonGubler @cwfitzgerald